Remove unused task action SegmentLockReleaseAction#16422
Merged
kfaraz merged 2 commits intoapache:masterfrom May 10, 2024
Merged
Remove unused task action SegmentLockReleaseAction#16422kfaraz merged 2 commits intoapache:masterfrom
kfaraz merged 2 commits intoapache:masterfrom
Conversation
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java
Outdated
Show resolved
Hide resolved
AmatyaAvadhanula
approved these changes
May 9, 2024
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
Left a minor comment, but otherwise LGTM.
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula ! |
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
May 10, 2024
Changes: - Remove `SegmentLockReleaseAction` as it is not used anywhere. It is not even registered as a known sub-type of `TaskAction`. - Minor refactor in `TaskLockbox`. No functional change. - Remove `ExpectedException` from `TaskLockboxTest`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
SegmentLockReleaseActionas it is not used anywhere. It is not even registered as a known sub-type ofTaskAction.TaskLockbox. No functional change.ExpectedExceptionfromTaskLockboxTest