docs: remove outdated druidversion var from a page#16570
Merged
asdf2014 merged 2 commits intoapache:masterfrom Jun 10, 2024
Merged
docs: remove outdated druidversion var from a page#16570asdf2014 merged 2 commits intoapache:masterfrom
asdf2014 merged 2 commits intoapache:masterfrom
Conversation
vtlim
approved these changes
Jun 6, 2024
asdf2014
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
{{DRUIDVERSION}}bits on this page were added awhile ago:https://github.com/apache/druid/blame/master/docs/querying/datasource.md
Line 368: last year (26.0.0)
Line 434: 4 years ago
I think they should have been hardcoded at the time since the statements mark a change in behavior. But since they were both so long ago, it seems like we can just remove them instead of trying to track down the version they correspond to.
At a minimum, I think we should remove the 4 yr old reference. If we wanted to, we can update line 368 to the actual version
This PR has: