Refactor: Miscellaneous batch task cleanup#16730
Merged
kfaraz merged 2 commits intoapache:masterfrom Jul 13, 2024
Merged
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
kfaraz
commented
Jul 12, 2024
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java
Show resolved
Hide resolved
abhishekrb19
approved these changes
Jul 13, 2024
| } | ||
|
|
||
| private static List<TimelineObjectHolder<String, DataSegment>> retrieveRelevantTimelineHolders( | ||
| private static Iterable<DataSegment> retrieveRelevantTimelineHolders( |
Contributor
There was a problem hiding this comment.
I guess the objects being returned is still relevant to the timeline, but does this method need a rename?
Contributor
Author
There was a problem hiding this comment.
Fair point, let me include that in the next PR.
Contributor
Author
|
Thanks a lot for the review, @abhishekrb19 ! |
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
Changes - No functional change - Remove unused method `IndexTuningConfig.withPartitionsSpec()` - Remove unused method `ParallelIndexTuningConfig.withPartitionsSpec()` - Remove redundant method `CompactTask.emitIngestionModeMetrics()` - Remove Clock argument from `CompactionTask.createDataSchemasForInterval()` as it was only needed for one test which was just verifying the value passed by the test itself. The code now uses a `Stopwatch` instead and test simply verifies that the metric has been emitted. - Other minor cleanup changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
IndexTuningConfig.withPartitionsSpec()ParallelIndexTuningConfig.withPartitionsSpec()CompactTask.emitIngestionModeMetrics()Clockargument fromCompactionTask.createDataSchemasForInterval()as it was only neededfor one test which was just verifying the value passed by the test itself. The code now uses a
Stopwatchinstead and test simply verifies that the metric has been emitted.