Tests: Add utility class TuningConfigBuilder to make IndexTask tests more readable and concise#16732
Merged
kfaraz merged 4 commits intoapache:masterfrom Jul 15, 2024
Merged
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
kfaraz
changed the title
| .forCompactionTask() | ||
| .withMaxRowsInMemory(500000) | ||
| .withMaxBytesInMemory(1000000L) | ||
| .withMaxTotalRows(Long.MAX_VALUE) |
Contributor
There was a problem hiding this comment.
Why is this needed?
Contributor
Author
There was a problem hiding this comment.
Oh, might have been copied over from somewhere else.
Will get rid of it in a follow up if that's okay (to avoid re-triggering CI.)
AmatyaAvadhanula
approved these changes
Jul 15, 2024
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
Thanks for the changes, @kfaraz!
Contributor
Author
|
Thanks a lot for the quick review, @AmatyaAvadhanula ! |
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
…more readable and concise (apache#16732) Changes: - No functional change - Add class `TuningConfigBuilder` to build `IndexTuningConfig`, `CompactionTuningConfig` - Remove old class `ParallelIndexTestingFactory.TuningConfigBuilder` - Remove some unused fields and methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TuningConfigBuilderto buildIndexTuningConfig,CompactionTuningConfigParallelIndexTestingFactory.TuningConfigBuilder