Benchmark for window functions#16824
Merged
kgyrtkirk merged 5 commits intoapache:masterfrom Aug 7, 2024
Merged
Conversation
kgyrtkirk
reviewed
Jul 31, 2024
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlWindowFnBenchmark.java
Outdated
Show resolved
Hide resolved
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlWindowFnBenchmark.java
Outdated
Show resolved
Hide resolved
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlWindowFnBenchmark.java
Outdated
Show resolved
Hide resolved
Comment on lines
+189
to
+197
| final Pair<PlannerFactory, SqlEngine> sqlSystem = createSqlSystem( | ||
| ImmutableMap.of(dataSegment, index), | ||
| Collections.emptyMap(), | ||
| null, | ||
| closer | ||
| ); | ||
|
|
||
| plannerFactory = sqlSystem.lhs; | ||
| engine = sqlSystem.rhs; |
Member
There was a problem hiding this comment.
I guess this was copied from somewhere?
createSqlSystem is a static method which returns a pair which gets assigned to class fields this seems pretty complicated...
we can have it like this for now - but it would be better to extract not relevant common pieces to a shared class or something...
kgyrtkirk
approved these changes
Aug 7, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a benchmark for window functions
Key changed/added classes in this PR
SqlWindowFnBenchmarkThis PR has: