Updated auth to use variables with default values#16876
Merged
techdocsmith merged 3 commits intoapache:masterfrom Aug 23, 2024
Merged
Updated auth to use variables with default values#16876techdocsmith merged 3 commits intoapache:masterfrom
techdocsmith merged 3 commits intoapache:masterfrom
Conversation
asdf2014
reviewed
Aug 14, 2024
techdocsmith
requested changes
Aug 15, 2024
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
The original ask was to put the curl auth in --auth rather than as parameters, but it looks like someone removed auth entirely from the curl requests.
Rather than add variables for the auth in the python examples, maybe let's just remove auth in python since it's off by default for Druid.
hevansDev
added a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
* Updated auth to use variables with default values * Update docs/api-reference/sql-ingestion-api.md * Remove Python auth entirely as its not being used --------- Co-authored-by: Benedict Jin <asdf2014@apache.org>
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Sep 5, 2024
* Updated auth to use variables with default values * Update docs/api-reference/sql-ingestion-api.md * Remove Python auth entirely as its not being used --------- Co-authored-by: Benedict Jin <asdf2014@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13193
Description
Updated format of Python API requests in docs to match @techdocsmith comments in #13436
Release note
Updated Python API request examples in docs
-->
This PR has: