Skip to content

Filter out tombstone segments from metadata cache#16890

Merged
cryptoe merged 18 commits intoapache:masterfrom
findingrish:fix-tombstone-refresh
Aug 20, 2024
Merged

Filter out tombstone segments from metadata cache#16890
cryptoe merged 18 commits intoapache:masterfrom
findingrish:fix-tombstone-refresh

Conversation

@findingrish
Copy link
Contributor

@findingrish findingrish commented Aug 13, 2024 •
edited
Loading

Broker attempts to continuously refresh tombstone segments due to missing metadata (due to a limitation with segment metadata queries, see: #12137).

This PR resolves the issue by preventing tombstone segments from being added to the metadata cache.

Related to #14989

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

rishabh singh added 14 commits March 14, 2024 16:49
cryptoe
cryptoe reviewed Aug 19, 2024
View reviewed changes
server/src/test/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCacheTest.java
}

@Test
public void testTombstoneSegmentIsNotAdded() throws InterruptedException
Copy link
Contributor

@cryptoe cryptoe Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This test case is very similar to BSMC#testTombstoneSegmentIsNotAdded(). Can we do a bit of refactor to remove redundancy.

Copy link
Contributor Author

@findingrish findingrish Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is trying ensure that tombstone segments are not added to the Broker and Coordinator cache instances.
Refactoring the test wouldn't be very beneficial since,

  • Timeline used in the two caches is different.
  • org.apache.druid.segment.metadata.AbstractSegmentMetadataCache#getSegmentMetadataSnapshot implementation differs between the two instances.

@cryptoe cryptoe merged commit bc4b3a2 into apache:master Aug 20, 2024
hevansDev pushed a commit to hevansDev/druid that referenced this pull request Aug 29, 2024
@findingrish @hevansDev
Filter out tombstone segments from metadata cache (apache#16890)
d21b324 
* Fix build

* Support segment metadata queries for tombstones

* Filter out tombstone segments from metadata cache

* Revert some changes

* checkstyle

* Update docs
@findingrish findingrish mentioned this pull request Sep 10, 2024
Merged
cryptoe pushed a commit that referenced this pull request Sep 13, 2024
@findingrish
Skip tombstone segment refresh in metadata cache (#17025)
a8c06e9 
This PR #16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish added a commit to findingrish/druid that referenced this pull request Sep 16, 2024
@findingrish
Skip tombstone segment refresh in metadata cache (apache#17025)
83a94df 
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish added a commit to findingrish/druid that referenced this pull request Sep 16, 2024
@findingrish
Skip tombstone segment refresh in metadata cache (apache#17025)
ec40659 
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
pranavbhole pushed a commit to pranavbhole/druid that referenced this pull request Sep 17, 2024
@findingrish @pranavbhole
Skip tombstone segment refresh in metadata cache (apache#17025)
0d68de4 
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish added a commit to findingrish/druid that referenced this pull request Sep 19, 2024
@findingrish
Skip tombstone segment refresh in metadata cache (apache#17025)
d7e3e75 
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
abhishekagarwal87 pushed a commit that referenced this pull request Sep 19, 2024
@findingrish
Skip tombstone segment refresh in metadata cache (#17025) (#17112)
60ed36c 
This PR #16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.

The fix is to keep the segment in the metadata cache but skip them from refresh.

This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees

No one assigned

Labels

Area - Querying Area - Segment Format and Ser/De

Projects

None yet

Milestone

31.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@findingrish @cryptoe @kfaraz