Skip to content

Fix NPE in ArrayListRowsAndColumns when intermediate column is not found#16897

Merged
asdf2014 merged 1 commit intoapache:masterfrom
sreemanamala:alrac-npe
Aug 15, 2024
Merged

Fix NPE in ArrayListRowsAndColumns when intermediate column is not found#16897
asdf2014 merged 1 commit intoapache:masterfrom
sreemanamala:alrac-npe

Conversation

@sreemanamala
Copy link
Contributor

Description

In ArrayListRowsAndColumns when we try to access an intermediate column which is not part of signature, we get an NPE

example query failing due to this:

select cityName, array_concat_agg(ARRAY[cityName], 10000) over (PARTITION BY cityName) as c
from wikipedia
where countryName='Austria'
group by cityName

Key changed/added classes in this PR
  • ArrayListRowsAndColumns

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 merged commit 964cf47 into apache:master Aug 15, 2024
@sreemanamala sreemanamala deleted the alrac-npe branch August 16, 2024 01:22
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants