Use multiple workers in MSQ WF drill test suite#16949
Merged
cryptoe merged 1 commit intoapache:masterfrom Aug 26, 2024
Merged
Conversation
cryptoe
approved these changes
Aug 23, 2024
Contributor
|
Failures seems unrelated to this PR. |
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, MSQ WF drill test suite uses maxNumTasks: 2 (default).
This means we can't detect any issues/regressions via this test, when we use multiple workers.
This PR updates the MSQ WF drill test suite to use maxNumTasks: 5.
However, there are some test cases which can give different correct results across different runs due to MixShuffleSpec being present in the previous stage. Such test cases have been overridden to use a single worker. This has been done for 8 tests.
Some tests have been modified to give deterministic result, while ensuring that the test is still validating what it was originally added for.
I've ran
MSQDrillWindowQueryTest20+ times locally to ensure no flakiness for any other test that's not overridden to use a single worker.This PR has: