GHA steps to collect and upload heap dumps to debug UT OOM errors#17029
Merged
abhishekrb19 merged 7 commits intoapache:masterfrom Sep 12, 2024
Merged
GHA steps to collect and upload heap dumps to debug UT OOM errors#17029abhishekrb19 merged 7 commits intoapache:masterfrom
abhishekrb19 merged 7 commits intoapache:masterfrom
Conversation
The path likely needs to come from externally
Co-authored-by: Elliott Freis <108356317+imply-elliott@users.noreply.github.com>
abhishekrb19
force-pushed
the
collect_heap_dumps_ut_oom
branch
from
6923b17 to
2920c2e
Compare
kgyrtkirk
approved these changes
Sep 12, 2024
Member
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
project.parent.basedir is already used ; and the module hierarchy is usually 1 level...we could accept the same risks...
+1
This was referenced Sep 12, 2024
cecemei
pushed a commit
to cecemei/druid
that referenced
this pull request
Sep 12, 2024
…ache#17029) * Add GHA steps to tar and upload any heap dumps on failure to debug UT OOM issues. * Add jvm options to heap dump OnOutOfMemoryError Co-authored-by: Elliott Freis <108356317+imply-elliott@users.noreply.github.com> --------- Co-authored-by: Elliott Freis <108356317+imply-elliott@users.noreply.github.com>
abhishekrb19
added a commit
that referenced
this pull request
Sep 13, 2024
#17054) A command line arg -XX:OnOutOfMemoryError='chmod 644 ${project.parent.basedir}/target/*.hprof' was added to collect heap dumps: #17029 This arg is causing problems when running tests from Intellij. Intellij doesn't seem to likechmod 644, but this command works as expected in mvn. So as a workaround, add the chmod 644 ${BASE_DIR/target/*.hprof' command in a shell script that can then be executed when OnOutOfMemoryError happens to make Intellij happy.
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Sep 17, 2024
apache#17054) A command line arg -XX:OnOutOfMemoryError='chmod 644 ${project.parent.basedir}/target/*.hprof' was added to collect heap dumps: apache#17029 This arg is causing problems when running tests from Intellij. Intellij doesn't seem to likechmod 644, but this command works as expected in mvn. So as a workaround, add the chmod 644 ${BASE_DIR/target/*.hprof' command in a shell script that can then be executed when OnOutOfMemoryError happens to make Intellij happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UTs have recently been failing with OOMs: https://github.com/apache/druid/actions/runs/10796374752/job/29955096914?pr=17027
So this PR adds some GHA steps to tarball and upload the heap dump if they exist.
This PR has: