DartWorkerContext: Return the correct workerId().#17280
Merged
gianm merged 1 commit intoapache:masterfrom Oct 8, 2024
Merged
Conversation
Prior to this patch, the workerId() method did not actually return the worker ID. It returned some other string that had similar information, but was different. This caused the /druid/dart-worker/workers API, to return an internal server error. The API is useful for debugging, although it is not used during actual queries.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
cryptoe
approved these changes
Oct 8, 2024
Contributor
Author
|
The CI failures are code coverage related. I am going to merge this anyway, since the class in question is kind of annoying to unit test. (It's a "context" object that takes a bunch of injected inputs and passes them through.) |
AmatyaAvadhanula
pushed a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Oct 9, 2024
Prior to this patch, the workerId() method did not actually return the worker ID. It returned some other string that had similar information, but was different. This caused the /druid/dart-worker/workers API, to return an internal server error. The API is useful for debugging, although it is not used during actual queries.
abhishekagarwal87
pushed a commit
that referenced
this pull request
Oct 9, 2024
Prior to this patch, the workerId() method did not actually return the worker ID. It returned some other string that had similar information, but was different. This caused the /druid/dart-worker/workers API, to return an internal server error. The API is useful for debugging, although it is not used during actual queries. Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the
workerId()method did not actually return the worker ID. It returned some other string that had similar information, but was different. This caused the/druid/dart-worker/workersAPI to return an internal server error. The API is useful for debugging, although it is not used during actual queries.