Support Union in Decoupled planning#17354
Merged
kgyrtkirk merged 206 commits intoapache:masterfrom Nov 5, 2024
Merged
Conversation
imply-cheddar
approved these changes
Oct 31, 2024
Contributor
imply-cheddar
left a comment
imply-cheddar
left a comment
There was a problem hiding this comment.
Left a few nitty type comments that don't need to be addressed to merge this. Address them if you agree/want to/have to make changes to satisfy the test bots anyway.
processing/src/main/java/org/apache/druid/query/AbstractQueryLogic.java
Outdated
Show resolved
Hide resolved
processing/src/main/java/org/apache/druid/query/union/UnionQueryRunner.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java
Outdated
Show resolved
Hide resolved
Member
Author
|
tests running jdk21 have bumped into the issue of #17429 |
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
* introduces `UnionQuery` * some changes to enable a `UnionQuery` to have multiple input datasources * `UnionQuery` execution is driven by the `QueryLogic` - which could later enable to reduce some complexity in `ClientQuerySegmentWalker` * to run the subqueries of `UnionQuery` there was a need to access the `conglomerate` from the `Runner`; to enable that some refactors were done * renamed `UnionQueryRunner` to `UnionDataSourceQueryRunner` * `QueryRunnerFactoryConglomerate` have taken the place of `QueryToolChestWarehouse` which shaves of some unnecessary things here and there * small cleanup/refactors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnionQueryUnionQueryto have multiple input datasourcesUnionQueryexecution is driven by theQueryLogic- which could later enable to reduce some complexity inClientQuerySegmentWalkerUnionQuerythere was a need to access theconglomeratefrom theRunner; to enable that some refactors were doneUnionQueryRunnertoUnionDataSourceQueryRunnerQueryRunnerFactoryConglomeratehave taken the place ofQueryToolChestWarehousewhich shaves of some unnecessary things here and there