Skip to content

kafka-indexing: Report consumer io time#17427

Closed
ac9817 wants to merge 1 commit intoapache:masterfrom
ac9817:io-kafka
Closed

kafka-indexing: Report consumer io time#17427
ac9817 wants to merge 1 commit intoapache:masterfrom
ac9817:io-kafka

Conversation

@ac9817
Copy link
Contributor

@ac9817 ac9817 commented Oct 28, 2024

Description

This PR adds the visibility into the io time spent by the kafka consumer during the index task. This helps us see if there is any correlation between this versus the future lag and could make changes to autoscaler strategies.

Also, adds datasource dimension to it to differentiate cases where both supervisors uses same topic.


Key changed/added classes in this PR
  • KafkaConsumerMonitor.java

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

sortingMapper,
spec.getIoConfig().getConfigOverrides(),
spec.getIoConfig().isMultiTopic()
spec.getIoConfig().isMultiTopic(),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [KafkaSupervisorSpec.getIoConfig](1) should be avoided because it has been deprecated.
@ac9817 ac9817 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant