Add documentation for Druids catalog extension#17459
Merged
zachjsh merged 15 commits intoapache:masterfrom Nov 12, 2024
Merged
Conversation
amaechler
reviewed
Nov 8, 2024
Contributor
amaechler
left a comment
amaechler
left a comment
There was a problem hiding this comment.
Only nits, thanks for adding!
Co-authored-by: Andreas Maechler <amaechler@gmail.com>
Contributor
Author
Thanks for reviewing @amaechler ! Think I addressed all of your comments. Good suggestions. |
amaechler
approved these changes
Nov 9, 2024
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
* SQL syntax error should target USER persona * * revert change to queryHandler and related tests, based on review comments * * add test * Add documentation for druid-catalog extension * * fix error * * fix error * Apply suggestions from code review Co-authored-by: Andreas Maechler <amaechler@gmail.com> * * fix spelling error * * fix spelling --------- Co-authored-by: Andreas Maechler <amaechler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds docs for Druids catalog extension
This PR has: