Rename d1/d2 column in tests#17471
Merged
kgyrtkirk merged 18 commits intoapache:masterfrom Nov 22, 2024
Merged
Conversation
This reverts commit 0d03cc5.
imply-cheddar
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDataBuilderdefinesd1/d2columnsDruidQuerycould be affected by the presence of those columns - as they may interfere with the prefix selectionDruidCorrelateUnnestRuleremoves a project fully while it operates - which may cause all underlying columns to appearIntroduction of
DruidRelFieldTrimmerwhich could remove unused columns underCorrelatecause lots of_differences between the decoupled and the old planner asDruidCorrelateUnnestRuleessentially undoes the trimming