[DISCUSS] Rewrite S3StorageConnectorTest using testcontainers and MinIO#17539
Merged
rohangarg merged 1 commit intoapache:masterfrom Dec 9, 2024
Merged
[DISCUSS] Rewrite S3StorageConnectorTest using testcontainers and MinIO#17539rohangarg merged 1 commit intoapache:masterfrom
rohangarg merged 1 commit intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| ) | ||
| .withCredentials(new StaticCredentialsProvider( | ||
| new BasicAWSCredentials(container.getUserName(), "wrong"))) |
Check failure
Code scanning / CodeQL
Hard-coded credential in API call
Contributor
|
I just tried this locally and it worked like a charm while running Docker Desktop. The test suite ran in less than a second. IMO this is a lot nicer than using mocks or ITs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to rewrite the
S3StorageConnectorTestas integration tests usingjava-testcontainersand MinIO container to simulate S3. This is to facilitate a discussion that whether we should write some of our test usingjava-testcontainersin future.Some features of this change :
localmaven profile), but always run on the CI (viaCIprofile)