Add back UnnecessaryFullyQualifiedName rule in pmd ruleset#17570
Merged
cryptoe merged 2 commits intoapache:masterfrom Dec 17, 2024
Merged
Add back UnnecessaryFullyQualifiedName rule in pmd ruleset#17570cryptoe merged 2 commits intoapache:masterfrom
UnnecessaryFullyQualifiedName rule in pmd ruleset#17570cryptoe merged 2 commits intoapache:masterfrom
Conversation
...on-tests/src/main/java/org/apache/druid/testing/utils/AvroSchemaRegistryEventSerializer.java
Show resolved
Hide resolved
kfaraz
approved these changes
Dec 16, 2024
Contributor
|
IMO the old style was better. Reading through the diff the new code often feels less clear. So I think we should revert this, and consider requiring that static methods be qualified. TBH I thought they were already required to be qualified outside tests. |
Akshat-Jain
added a commit
to Akshat-Jain/druid
that referenced
this pull request
Dec 18, 2024
…pache#17570)" This reverts commit cd6083f.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #17466, we had added exclusion for
UnnecessaryFullyQualifiedNamerule to avoid a large number of irrelevant changes to the PR on upgradingmaven-pmd-pluginversion.This PR re-visits that and adds back the
UnnecessaryFullyQualifiedNamerule, fixing all violations of the rule across the project.This PR has: