Skip to content

Add back UnnecessaryFullyQualifiedName rule in pmd ruleset#17570

Merged
cryptoe merged 2 commits intoapache:masterfrom
Akshat-Jain:add-UnnecessaryFullyQualifiedName-rule
Dec 17, 2024
Merged

Add back UnnecessaryFullyQualifiedName rule in pmd ruleset#17570
cryptoe merged 2 commits intoapache:masterfrom
Akshat-Jain:add-UnnecessaryFullyQualifiedName-rule

Conversation

@Akshat-Jain
Copy link
Contributor

@Akshat-Jain Akshat-Jain commented Dec 16, 2024

Description

In #17466, we had added exclusion for UnnecessaryFullyQualifiedName rule to avoid a large number of irrelevant changes to the PR on upgrading maven-pmd-plugin version.

This PR re-visits that and adds back the UnnecessaryFullyQualifiedName rule, fixing all violations of the rule across the project.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cryptoe cryptoe merged commit cd6083f into apache:master Dec 17, 2024
@gianm
Copy link
Contributor

gianm commented Dec 18, 2024

IMO the old style was better. Reading through the diff the new code often feels less clear. So I think we should revert this, and consider requiring that static methods be qualified. TBH I thought they were already required to be qualified outside tests.

Akshat-Jain added a commit to Akshat-Jain/druid that referenced this pull request Dec 18, 2024
gianm pushed a commit that referenced this pull request Dec 18, 2024
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants