Add remaining 6 sets of SQL tests in quidem#17583
Merged
cryptoe merged 1 commit intoapache:masterfrom Dec 19, 2024
Merged
Conversation
This is the 2nd part of the PR apache#17548. It migrates the remaining 6 sets of SQL tests to quidem. These 6 sets cover aggregation, array, json, mv, reduction, and other scalar functions. These tests use the existing kttm dataset. They aim to exercise SQL queries in a more comprehensive way: Aggregation functions: Each aggregation function is exercised in 1 query shape: group by query Each query covers all operators in the predicates of the having clause. All queries are designed to return 7 rows. Scalar functions: Each scalar function is exercised in 3 different query shapes: simple query subquery group by query Each query covers all operators in the predicates of the where clause. All queries are select count(*) queries. They are designed to all return the same result for easy maintenance and debugging. Update array and mv tests to use the language column This PR updates the array and the mv tests to use the MV column "language" instead of constructing the data in the queries.
8ea8a51 to
4e3ac07
Compare
cryptoe
approved these changes
Dec 19, 2024
Contributor
cryptoe
left a comment
There was a problem hiding this comment.
Thanks @weishiuntsai for adding these much needed tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 2nd PR as the follow-up of the PR #17548. It migrates the remaining 6 sets of SQL tests to quidem. These 6 sets cover aggregation, array, json, mv, reduction, and other scalar functions.
These tests use the existing kttm dataset. They aim to exercise SQL queries in a more comprehensive way:
Aggregation functions:
group by query
havingclause.Scalar functions:
simple query
subquery
group by query
whereclause.This PR has: