docs: add missing JSON field rowSignature in response examples when u…#17618
docs: add missing JSON field rowSignature in response examples when u…#17618kgyrtkirk merged 2 commits intoapache:masterfrom
Conversation
thomas-dufour
force-pushed
the
fix-issue-17586
branch
from
282c896 to
41af0e7
Compare
…sing scan queries
thomas-dufour
force-pushed
the
fix-issue-17586
branch
from
41af0e7 to
141d9e6
Compare
docs/querying/scan-query.md
Outdated
| @@ -45,10 +45,10 @@ An example Scan query object is shown below: | |||
| "resultFormat": "list", | |||
| "columns":[], | |||
There was a problem hiding this comment.
how about selecting just a few columns? so that the data/signature doesn't fill half the screen?
There was a problem hiding this comment.
I did that. If we want the rowSignature to be even more compact, I can format it a bit differently (but the format will not be at linter standard)
There was a problem hiding this comment.
yeah - I also hate the terse json formatting...some time ago I was playing with jackson to make it a bit nicer everywhere on a branch - but it was so outside of scope with what I was doing so I reverted those changes.
the relevant commit is here feel free to pick it up - I don't have time to finish it.
I guess the change in the above commit aren't linter standard either :)
There was a problem hiding this comment.
just to be clear, I can't tell if you are expecting me to do something more. Can we resolve this thread?
Also, should I do anything more after your approbation?
There was a problem hiding this comment.
I was just mentioning that - that's all :)
|
note: you could just add further commits and avoid force push - the PR will be squashed on merge anyway |
…sing scan queries
|
@thomas-dufour: your email address You could associate that email address with your gh account following this doc - or would you like me to go ahead and merge it as-is? |
Ah thanks, I set it as public. It should appears clearly now |
|
thank you for fixing this @thomas-dufour ! :) |
2 participants
docs: add missing JSON field rowSignature in response examples when using scan queries
Fixes #17586.
Description
I found out the documentation about scan queries was out of date. Therefore, I updated the documentation with the actual response format returned by a local Druid v31.