Handle intermediate change of status in pause method#17723
Merged
kfaraz merged 5 commits intoapache:masterfrom Feb 16, 2025
Merged
Handle intermediate change of status in pause method#17723kfaraz merged 5 commits intoapache:masterfrom
kfaraz merged 5 commits intoapache:masterfrom
Conversation
kfaraz
reviewed
Feb 13, 2025
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the PR, @suraj-goel !
I have left some thoughts. Let me know what you think.
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
kfaraz
reviewed
Feb 15, 2025
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Changes look good to me.
Left some minor suggestions.
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
Contributor
Author
@kfaraz , I have addressed the comments. |
kfaraz
reviewed
Feb 16, 2025
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
kfaraz
reviewed
Feb 16, 2025
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
cryptoe
approved these changes
Feb 16, 2025
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
Show resolved
Hide resolved
kfaraz
approved these changes
Feb 16, 2025
airlock-confluentinc bot
pushed a commit
to confluentinc/druid
that referenced
this pull request
Feb 17, 2025
….pause() (apache#17723) This patch addresses error messages like: Can't pause, task is not in a pausable state (state: [PAUSED])
10 tasks
suraj-goel
added a commit
to confluentinc/druid
that referenced
this pull request
Feb 17, 2025
….pause() (apache#17723) (#306) Backport commit
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17722.
Description
Fixed the bug
statusis changing during the evaluation of theifstatement.Release note
Key changed/added classes in this PR
SeekableStreamIndexTaskRunner.javaThis PR has: