Skip to content

Handle intermediate change of status in pause method#17723

Merged
kfaraz merged 5 commits intoapache:masterfrom
confluentinc:fix-17722
Feb 16, 2025
Merged

Handle intermediate change of status in pause method#17723
kfaraz merged 5 commits intoapache:masterfrom
confluentinc:fix-17722

Conversation

@suraj-goel
Copy link
Contributor

@suraj-goel suraj-goel commented Feb 13, 2025

Fixes #17722.

Description

Fixed the bug

  • After upgrading to Druid-30, One task is occasionally failing per day.
  • Task fails with the following exception:
Can't pause, task is not in a pausable state (state: [PAUSED])
Feb 12, 2025 @ 15:21:08.165	Pausing the task with state: [READING]

Feb 12, 2025 @ 15:21:08.165	Returning 409 conflict for task with state: [PAUSED]
  • As per the above logs, status is changing during the evaluation of the if statement.

Release note


Key changed/added classes in this PR
  • SeekableStreamIndexTaskRunner.java

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @suraj-goel !
I have left some thoughts. Let me know what you think.

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Left some minor suggestions.

@suraj-goel
Copy link
Contributor Author

Changes look good to me. Left some minor suggestions.

@kfaraz , I have addressed the comments.

@kfaraz kfaraz merged commit 0dd4862 into apache:master Feb 16, 2025
74 checks passed
airlock-confluentinc bot pushed a commit to confluentinc/druid that referenced this pull request Feb 17, 2025
….pause() (apache#17723)

This patch addresses error messages like:
Can't pause, task is not in a pausable state (state: [PAUSED])
suraj-goel added a commit to confluentinc/druid that referenced this pull request Feb 17, 2025
@kgyrtkirk kgyrtkirk added this to the 33.0.0 milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task Fails on pause request due to intermediate change in task status

4 participants