Fix filters on TIMESTAMP_TO_MILLIS over TIME_FLOOR.#17871
Merged
gianm merged 3 commits intoapache:masterfrom Apr 28, 2025
Merged
Fix filters on TIMESTAMP_TO_MILLIS over TIME_FLOOR.#17871gianm merged 3 commits intoapache:masterfrom
gianm merged 3 commits intoapache:masterfrom
Conversation
It is possible for toQueryGranularity to return nonnull for BIGINT rhs, in the case where the time floor expression is wrapped in TIMESTAMP_TO_MILLIS. Prior to this patch, that would throw an (incorrect) error about expecting a literal. This patch fixes the defensive error to have the correct message (in Calcites) and also fixes the filter translation code to not hit that defensive check (in Expressions).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
clintropolis
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for toQueryGranularity to return nonnull for BIGINT rhs, in the case where the time floor expression is wrapped in TIMESTAMP_TO_MILLIS. Prior to this patch, that would throw an (incorrect) error about expecting a literal.
This patch fixes the defensive error to have the correct message (in Calcites) and also fixes the filter translation code to not hit that defensive check (in Expressions).