Fix ExprEval of BigDecimal data type#17889
Merged
gianm merged 1 commit intoapache:masterfrom Apr 8, 2025
Merged
Conversation
gianm
approved these changes
Apr 8, 2025
Contributor
gianm
left a comment
There was a problem hiding this comment.
LGTM, seems like a reasonable thing to do for bestEffortOf, since there isn't a native big-decimal type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ExprEval of BigDecimal data type
Description
This PR fixes a regression caused by #13947 (more specifically at https://github.com/apache/druid/pull/13947/files#diff-199493eb5b59a386d1fcade78da6578074cd94c80c114cfdd875a218106ca302L127 was changed to https://github.com/apache/druid/pull/13947/files#diff-5be9af304a8dda2062ca806bcc5320628757609c441fee5aec6e1ce51f71ded6R120)
Previously, we were just returning the raw but now we are using the method bestEffortOf which incorrectly handle BigDecimal data type. BigDecimal data type is incorrectly converted to Long. This issue was discovered with ingestion of Parquet files which use BigDecimal data type
Key changed/added classes in this PR
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java
This PR has: