-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Call stopBeingLeader() if becomeLeader() fails #17927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server/src/main/java/org/apache/druid/curator/discovery/CuratorDruidLeaderSelector.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/curator/discovery/CuratorDruidLeaderSelector.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/curator/discovery/CuratorDruidLeaderSelector.java
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback, @gianm ! |
|
LGTM. Coverage checker is unhappy; is it possible/useful to add coverage, or should we ignore it? Probably the |
|
Thanks for the review, @gianm ! |
Description
If a master node fails to acquire leadership due to exception while calling
listener.becomeLeader(),listener.stopBeingLeader()must be called in order to ensure that there are no modules whichcontinue to believe that they are still the leader.
This PR has: