Skip to content

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Apr 16, 2025

Description

#10308 had made a change to start assigning the SeekableStreamIndexTaskRunner.authorizerMapper
in the runTask method rather than the constructor, but that PR missed removing it from the constructor
and it has just been dangling since then.

Spotbugs seems to have finally found this issue.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@gianm gianm merged commit 0ef39a3 into apache:master Apr 16, 2025
74 checks passed
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants