Move ReadResourceActions validation earlier in QueryHandler#17946
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 25, 2025
Merged
Move ReadResourceActions validation earlier in QueryHandler#17946cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
cryptoe
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was poking around in
QueryHandlerand I can't figure out why this validation should be postponed up until the resultsupplier is created - history goes back to 2021 so that didn't helped...I don't think anything break if I the check would be done earlier; possibly more
context: doing it the other way could possibly skip this validation for future
QkSqlEngine(old planner + earlyQueryDefinitionsubmission)