Avoid using Curator's shaded Guava.#18011
Merged
gianm merged 5 commits intoapache:masterfrom May 16, 2025
Merged
Conversation
IDEs sometimes auto-complete Guava classes using Curator's shaded versions. We don't want to use this. This patch switches all such cases to regular Guava, and adds a checkstyle rule to catch future cases.
kfaraz
approved these changes
May 16, 2025
kgyrtkirk
approved these changes
May 16, 2025
Member
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
I was also preparing the same yesterday - for exactly the same reasons :)
should have opened the PR
master...kgyrtkirk:ban-shaded-curator
Member
|
close/open to restart and supress jacoco |
Contributor
Author
Oops 🫣 Also, I see you used forbidden-apis in the branch you were working on. That is a better idea than a checkstyle regexp, so I updated this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDEs sometimes auto-complete Guava classes using Curator's shaded versions. We don't want to use this. This patch switches all such cases to regular Guava, and adds a checkstyle rule to catch future cases.