acquire segment references in bulk for ServerManager to simplify reference handling#18054
Merged
clintropolis merged 5 commits intoapache:masterfrom May 30, 2025
Merged
Conversation
server/src/test/java/org/apache/druid/server/TestClusterQuerySegmentWalker.java
Fixed
Show fixed
Hide fixed
gianm
approved these changes
May 30, 2025
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jun 1, 2025
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #18005, this PR changes
ServerManagerto acquire segment references in bulk before building query runners instead of lazily during the processing of the segment. I think that this should also help reduce the chance for segments to be dropped before being processed since grabbing the reference for each segment is not dependent on when that segments runner runs, in exchange for holding the reference a bit longer.ReferenceCountingSegmentQueryRunneris no longer needed and has been deleted.Also did some minor code cleanup in
SegmentManagerto tidy things up (no logic changes).This PR has: