Skip to content

Clean up some jackson dependency excludes by moving it to top level pom#18190

Merged
capistrant merged 1 commit intoapache:masterfrom
capistrant:fixup-jackson-dep-excludes-mess
Jul 2, 2025
Merged

Clean up some jackson dependency excludes by moving it to top level pom#18190
capistrant merged 1 commit intoapache:masterfrom
capistrant:fixup-jackson-dep-excludes-mess

Conversation

@capistrant
Copy link
Contributor

Description

follow on to #18013. It was pointed out, after merge, that I should have consolidated the excludes for two of the jackson libraries in the root pom instead of adding one off to every module that needed it. This aims to rectify that mistake. It also found another location where comments called for removing an explicit snakeyaml version pin in a module once jackson got upgraded.

Release note

N/A


Key changed/added classes in this PR
  • pom.xml

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Dependencies Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Jul 2, 2025
Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@capistrant capistrant merged commit 50506f2 into apache:master Jul 2, 2025
163 of 165 checks passed
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - Dependencies Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants