Skip to content

Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build script now is responsible to make sure it's non-empty. #18279

Merged
cryptoe merged 3 commits intoapache:masterfrom
cecemei:docker-it
Jul 18, 2025
Merged

Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build script now is responsible to make sure it's non-empty. #18279
cryptoe merged 3 commits intoapache:masterfrom
cecemei:docker-it

Conversation

@cecemei
Copy link
Contributor

@cecemei cecemei commented Jul 18, 2025 •
edited
Loading

Description

Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build script now is responsible to make sure it's non-empty.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cecemei cecemei marked this pull request as ready for review July 18, 2025 01:09
@capistrant capistrant added this to the 34.0.0 milestone Jul 18, 2025
@capistrant
Copy link
Contributor

capistrant commented Jul 18, 2025

The failing IT is the other one that has been flaking bad in addition to security :sad:

@cryptoe cryptoe merged commit edf2162 into apache:master Jul 18, 2025
75 of 76 checks passed
capistrant pushed a commit to capistrant/incubator-druid that referenced this pull request Jul 18, 2025
@cecemei @capistrant
Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build …
9619a89 
…script now is responsible to make sure it's non-empty. (apache#18279)

* some docker image change

* delete run-mysql
@capistrant capistrant mentioned this pull request Jul 18, 2025
Merged
capistrant added a commit that referenced this pull request Jul 18, 2025
@capistrant @cecemei
Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build …
cd86d82 
…script now is responsible to make sure it's non-empty. (#18279) (#18285)

* some docker image change

* delete run-mysql

Co-authored-by: Cece Mei <yingqian.mei@gmail.com>
ashibhardwaj pushed a commit to ashibhardwaj/druid that referenced this pull request Jul 23, 2025
@cecemei @ashibhardwaj
Remove the hardcoded MYSQL_DRIVER_CLASSNAME from Dockerfile, build …
c45d811 
…script now is responsible to make sure it's non-empty. (apache#18279)

* some docker image change

* delete run-mysql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@capistrant capistrant capistrant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

34.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cecemei @capistrant @cryptoe