Fix supervisor to tasks view naviagation in the console#18298
Fix supervisor to tasks view naviagation in the console#18298abhishekrb19 merged 2 commits intomasterfrom
Conversation
|
Tagging this with the 34.0.0 milestone since it’s a bug introduced with #18082. The fix is small enough that it’s likely worth backporting. cc: @capistrant |
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
LGTM 🚀
Verified in an embedded test.
|
@abhishekrb19 Since #18082 is experimental, I think its okay if we do this patch in Druid 35. |
|
I'm inclined to avoid any more creep into Druid34 wherever possible as I was hoping to move on to RC process ASAP. @abhishekrb19 do you have a feel for how impactful this is in the community? Is it just a UX issue with a work-a-round making a few extra clicks? |
The broken "Go to tasks" navigation for running tasks from the supervisors page in the console affects all new supervisors created after #18082, not just those with multiple supervisors. It's a UX inconvenience, as the default filters won't return any results, but it can be worked around with a few extra clicks/keystrokes in the task view.
@capistrant I've removed the milestone tag, but please feel free to backport it to 34.0.0 as you see fit. |
|
Thanks @abhishekrb19 for clarifying. |
With apache#18082, the supervisor ID is no longer the same as the datasource name, which breaks the navigation from the supervisors page to the corresponding tasks view. To fix the broken filter during navigation, use the groupId filter instead of datasource name when navigating from the supervisors to tasks view.
|
@abhishekrb19 Sorry I misunderstood the scope as well. Added back the 34.0.0 label since this is not just experimental supervisor facing |
) With #18082, the supervisor ID is no longer the same as the datasource name, which breaks the navigation from the supervisors page to the corresponding tasks view. To fix the broken filter during navigation, use the groupId filter instead of datasource name when navigating from the supervisors to tasks view. Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com>
With apache#18082, the supervisor ID is no longer the same as the datasource name, which breaks the navigation from the supervisors page to the corresponding tasks view. To fix the broken filter during navigation, use the groupId filter instead of datasource name when navigating from the supervisors to tasks view.
4 participants
With apache/druid#18082, the supervisor ID is no longer the same as the datasource name, which breaks the navigation from the supervisors page to the corresponding tasks view.
Fix:
Use the
groupIdfilter instead of datasource name when navigating from the supervisors to tasks view. This filter is used by other task types too. I think another alternative and cleaner approach would be to add the supervisor ID to thesys.taskstable and filter by it explicitly, but that would be a larger server-side change.This PR has: