Put errors on warning level for cpu set snapshots#18356
Merged
cryptoe merged 1 commit intoapache:masterfrom Aug 5, 2025
Merged
Put errors on warning level for cpu set snapshots#18356cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
cryptoe
reviewed
Aug 4, 2025
| } | ||
| catch (RuntimeException | IOException ex) { | ||
| LOG.error(ex, "Unable to read %s", file); | ||
| LOG.noStackTrace().warn(ex, "Unable to read %s, these metrics will be skipped", file); |
Contributor
There was a problem hiding this comment.
Nit: IMHO, it might be better to add all the CPUS_FILE, EFFECTIVE_CPUS_FILE etc in an array and then replace these with the exact metric name. That would help admins to figure out what happens with CPUS_FILE since the cluster admin would most likely grep for the particular string.
Contributor
Author
There was a problem hiding this comment.
@cryptoe , The file name will be mentioned here in the log already, just in separate log lines.
cryptoe
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending appropriate warnings when cpuset metrics are not available