Skip to content

Improve error message if task fails to return start time#18685

Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom
kfaraz:log_fail_to_return_start_time
Oct 22, 2025
Merged

Improve error message if task fails to return start time#18685
abhishekagarwal87 merged 1 commit intoapache:masterfrom
kfaraz:log_fail_to_return_start_time

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Oct 22, 2025

Description

While running the K8s task runner, tasks sometimes fail with the error message:

Task[xyz] failed to return start time, killing task.

The Overlord logs contain slightly more info

Task[xyz] failed to return start time, killing task. Service [xyz] handler closed unexpectedly.

Changes

  • Improve task failure error message. New message would be:
Failed to return start time: Service [xyz] handler closed unexpectedly.
  • Add log line in ServiceClientImpl to identify root cause in future failures.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekagarwal87 abhishekagarwal87 merged commit 991bf28 into apache:master Oct 22, 2025
30 of 31 checks passed
@kfaraz kfaraz deleted the log_fail_to_return_start_time branch October 22, 2025 08:49
@kfaraz
Copy link
Contributor Author

kfaraz commented Oct 22, 2025

Thanks for the reviews, @cryptoe , @abhishekagarwal87 !

@kgyrtkirk kgyrtkirk added this to the 36.0.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants