Support AWS InternalError code retries #18720
Merged
+102
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uds5501
changed the title
Akshat-Jain
reviewed
Nov 6, 2025
| return true; | ||
| } else if (e instanceof AmazonS3Exception && e.getMessage().contains("InternalError")) { | ||
| // This can happen sometimes when AWS returns a 200 response with internal error message | ||
| // https://repost.aws/knowledge-center/s3-resolve-200-internalerror |
Contributor
There was a problem hiding this comment.
This link also suggests SlowDown keyword might need similar behaviour, shall we add that too?
Quoting from the link:
A 200 response with InternalError or SlowDown is similar to a 5xx error. Because Amazon S3 is a distributed system, it's normal to see a small percentage of 200 internal errors. It's a best practice to retry these requests.
Contributor
There was a problem hiding this comment.
Should we also check the status code ? Internal error seems to be a bit too loose no ?
cryptoe
approved these changes
Nov 6, 2025
Contributor
|
Merging since failure is due to an unrelated flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports AWS S3's InternalError retries, for more information about the error, please refer - https://repost.aws/knowledge-center/s3-resolve-200-internalerror
This PR has: