Migrate ITAppendBatchIndexTest, ITCustomCoordinatorDutiesTest to embedded tests #18867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
changed the title
abhishekrb19
approved these changes
Dec 26, 2025
docs/development/modules.md
Outdated
| druid.coordinator.dutyGroups=["cleanupMetadata"] | ||
| druid.coordinator.cleanupMetadata.duties=["killSupervisors"] | ||
| druid.coordinator.cleanupMetadata.duty.killSupervisors.durationToRetain=PT0M | ||
| druid.coordinator.cleanupMetadata.period=PT10S |
Contributor
There was a problem hiding this comment.
Suggested change
| druid.coordinator.cleanupMetadata.period=PT0.1S |
Perhaps we can just remove the config block here, since it’s likely to go out of sync with the source of truth and have readers refer to KillSupervisorsCustomDutyTest.
Contributor
Author
|
Thanks for the review, @abhishekrb19 ! |
Contributor
Author
|
@abhishekrb19 , I have updated the docs. I also realised that the |
Contributor
Sweet. For posterity, maybe link the PRs in the summary where this migration was completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ITAppendBatchIndexTestwith a new method inIndexParallelTaskTestITCustomCoordinatorDutiesTestto embedded tests asKillSupervisorsCustomDutyTestinput-source(Migrate query JDBC, cancel and system tables tests, cleanup and refactor helper classes #18805, ITSqlQueryTest migration to embedded test suite #18752)cds-task-schema-publish-disabledcds-coordinator-metadata-query-disabledThis PR has: