Skip to content

Simplify response of /handoff API, fix test flakiness#18884

Merged
capistrant merged 2 commits intoapache:masterfrom
kfaraz:fix_et_flakiness
Jan 5, 2026
Merged

Simplify response of /handoff API, fix test flakiness#18884
capistrant merged 2 commits intoapache:masterfrom
kfaraz:fix_et_flakiness

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jan 5, 2026

Changes

  • Send back no body in response of handoff API instead of empty json ({})
  • Fix flakiness in FaultyClusterTest

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@capistrant
Copy link
Contributor

TY Kashif, I added a release notes label so we can remember to call out the response change, even if it is minor

@capistrant capistrant merged commit cf7d232 into apache:master Jan 5, 2026
71 of 72 checks passed
@kfaraz kfaraz deleted the fix_et_flakiness branch January 5, 2026 15:21
@kfaraz
Copy link
Contributor Author

kfaraz commented Jan 5, 2026

Thanks for the review, @capistrant !

@kgyrtkirk kgyrtkirk added this to the 36.0.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments