fix json column isNumeric check to properly consider array element selector types #18948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
cecemei
approved these changes
Jan 23, 2026
| } | ||
| } | ||
| return true; | ||
| return field == null; |
Contributor
There was a problem hiding this comment.
would be more readable if this just returns true (and return false as i commented above). also might be helpful adding explanation like this field doesnt exist, thus we can vectorized....
Member
Author
There was a problem hiding this comment.
I guess i was thinking that if we ever add any other types of path parts here then they will default to 'not numeric' instead of 'numeric'
| ).getCapabilities().getElementType(); | ||
| if (elementType != null) { | ||
| return elementType.isNumeric(); | ||
| } |
Contributor
There was a problem hiding this comment.
would be helpful to add some explanation here say if elementType not derived, we dont know this field is numeric or not... also might be just more readable return false directly after the if statement.
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression of sorts from refactoring in #18589, the
isNumericcheck was always returningtruewhen it really should have only been returningtrueif the field is a numeric type or non-existent. Improved the check to return true if the field is a numeric array with an array element path.