SegementCacheManager: acquireCachedSegment with SegmentId.#19044
Merged
gianm merged 3 commits intoapache:masterfrom Feb 23, 2026
Merged
SegementCacheManager: acquireCachedSegment with SegmentId.#19044gianm merged 3 commits intoapache:masterfrom
gianm merged 3 commits intoapache:masterfrom
Conversation
Prior to this patch, acquireCachedSegment required the entire DataSegment object. This patch loosens the requirement to just the SegmentId. This is useful under MSQ, where caching is fully on-demand (no load rules) and the full DataSegment object is not necessarily available in the local timeline, even if a segment is cached locally. See the change in RegularLoadableSegment.
github-actions
bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
clintropolis
approved these changes
Feb 22, 2026
Contributor
Author
|
The failure was in Docker tests due to 19047, merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, acquireCachedSegment required the entire DataSegment object. This patch loosens the requirement to just the SegmentId.
This is useful under MSQ, where caching is fully on-demand (no load rules) and the full DataSegment object is not necessarily available in the local timeline, even if a segment is cached locally. See the change in RegularLoadableSegment.