Skip to content

Fix add-milestone GHA job#19081

Merged
abhishekrb19 merged 1 commit intoapache:masterfrom
abhishekrb19:milestone_fix
Mar 4, 2026
Merged

Fix add-milestone GHA job#19081
abhishekrb19 merged 1 commit intoapache:masterfrom
abhishekrb19:milestone_fix

Conversation

@abhishekrb19
Copy link
Contributor

@abhishekrb19 abhishekrb19 commented Mar 4, 2026

A GitHub action to auto-add milestones were added in #18935

As @kgyrtkirk noted in this comment, this check is failing with a 403 error for all PRs coming from forks once they are merged into master:

{"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/issues/issues#update-an-issue","status":"403"}

Given the 403, it does indicate a permissions issue likely with the GitHub token used for this. Trying pull_request_target instead of pull_request similar to the existing labeler action which uses the same. Since this specific add-milestone check doesn't export any credentials, I believe using pull_request_target should be okay. Hopefully, with the elevated base token, this should work. 🤞

@github-actions github-actions bot added the GHA label Mar 4, 2026
@abhishekrb19 abhishekrb19 changed the title Try pull_request_target instead of pull_request Try fixing add-milestone GHA job Mar 4, 2026
Copy link
Contributor

@capistrant capistrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@abhishekrb19 abhishekrb19 merged commit 51bb678 into apache:master Mar 4, 2026
86 of 89 checks passed
@github-actions github-actions bot added this to the 37.0.0 milestone Mar 4, 2026
@abhishekrb19
Copy link
Contributor Author

Thanks for the review, @capistrant!

The milestone has been successfully added now. We'll still need to manually add the 37.0.0 milestone for existing PRs where it wasn’t added bc of the 403, but this should work going forward for new PRs.

@abhishekrb19 abhishekrb19 deleted the milestone_fix branch March 4, 2026 04:15
@abhishekrb19 abhishekrb19 changed the title Try fixing add-milestone GHA job Fix add-milestone GHA job Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants