Merged
Conversation
Contributor
Author
|
Thanks for the review, @capistrant! The milestone has been successfully added now. We'll still need to manually add the 37.0.0 milestone for existing PRs where it wasn’t added bc of the 403, but this should work going forward for new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GitHub action to auto-add milestones were added in #18935
As @kgyrtkirk noted in this comment, this check is failing with a 403 error for all PRs coming from forks once they are merged into master:
{"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/issues/issues#update-an-issue","status":"403"}Given the 403, it does indicate a permissions issue likely with the GitHub token used for this. Trying
pull_request_targetinstead ofpull_requestsimilar to the existing labeler action which uses the same. Since this specific add-milestone check doesn't export any credentials, I believe usingpull_request_targetshould be okay. Hopefully, with the elevated base token, this should work. 🤞