Wait for SQL table visibility in embedded tests.#19095
Merged
gianm merged 3 commits intoapache:masterfrom Mar 5, 2026
Merged
Conversation
Several embedded tests wait for segment/schemaCache/refresh/count as a proxy for when a datasource is queryable via SQL. However, this metric is emitted before the SQL table is set up. This creates a window where SQL queries can fail with "Object 'datasource' not found". This patch waits for segment/schemaCache/rowSignature/column/count, which is emitted after a SQL table is set up and visible. This is done either as a replacement for segment/schemaCache/refresh/count (if we only care about table visibility) or in addition to it (if we also want to wait for a specific number of segments to be detected).
kfaraz
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several embedded tests wait for segment/schemaCache/refresh/count as a proxy for when a datasource is queryable via SQL. However, this metric is emitted before the SQL table is set up. This creates a window where SQL queries can fail with "Object 'datasource' not found".
This patch waits for segment/schemaCache/rowSignature/column/count, which is emitted after a SQL table is set up and visible. This is done either as a replacement for segment/schemaCache/refresh/count (if we only care about table visibility) or in addition to it (if we also want to wait for a specific number of segments to be detected).