MSQ: Fix totalFiles tracking when querying data servers.#19104
Merged
gianm merged 1 commit intoapache:masterfrom Mar 9, 2026
Merged
MSQ: Fix totalFiles tracking when querying data servers.#19104gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
When we query realtime servers, we gather up any handed-off segments into a new SegmentsInputSlice and reattach it. This would cause setTotalFiles to be called, which overwrites the previous value, often with zero. This patch changes setTotalFiles to addTotalFiles, meaning that if any segments are handed-off and need to be fetched directly, the total file count will go up.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
capistrant
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we query realtime servers, we gather up any handed-off segments into a new SegmentsInputSlice and reattach it. This would cause setTotalFiles to be called, which overwrites the previous value, often with zero.
This patch changes setTotalFiles to addTotalFiles, meaning that if any segments are handed-off and need to be fetched directly, the total file count will go up.