Skip to content

Move ITS3AssumeRoleIndexTest and ITS3OverrideCredentialsIndexTest#19108

Merged
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:migrate_s3_tests
Mar 7, 2026
Merged

Move ITS3AssumeRoleIndexTest and ITS3OverrideCredentialsIndexTest#19108
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:migrate_s3_tests

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Mar 7, 2026

Changes

  • Add method in MinIOStorageResource to create temporary credentials using AssumeRoleRequest
  • Add test method to ITS3ToS3ParallelIndexTest to test ingestion with temporary override credentials
  • It is currently not possible to test assumeRoleArn/assumeRoleExternalId using Min IO since they are not supported
  • Remove old integration tests

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
Copy link
Copy Markdown
Contributor Author

kfaraz commented Mar 7, 2026

Thanks for the review, @clintropolis !

@kfaraz kfaraz merged commit 6c24c50 into apache:master Mar 7, 2026
62 of 63 checks passed
@kfaraz kfaraz deleted the migrate_s3_tests branch March 7, 2026 12:04
@github-actions github-actions bot added this to the 37.0.0 milestone Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants