Skip to content

Add minor fixes to follow up #19091#19119

Merged
capistrant merged 6 commits intoapache:masterfrom
kfaraz:follow_up_19091
Mar 10, 2026
Merged

Add minor fixes to follow up #19091#19119
capistrant merged 6 commits intoapache:masterfrom
kfaraz:follow_up_19091

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Mar 10, 2026 •
edited
Loading

Description

Contains minor fixes needed after #19091

Changes

  • Fix arguments to log message
  • Throw DruidException outside try to avoid swallowing them up
  • Perform cleanup in SeekableStreamSupervisor.maybeScaleDownDuringRollover()

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz requested a review from capistrant March 10, 2026 06:26
@capistrant capistrant merged commit 760e7e4 into apache:master Mar 10, 2026
62 of 63 checks passed
@github-actions github-actions bot added this to the 37.0.0 milestone Mar 10, 2026
@kfaraz kfaraz deleted the follow_up_19091 branch March 10, 2026 14:49
@kfaraz
Copy link
Copy Markdown
Contributor Author

kfaraz commented Mar 10, 2026

Thanks for the reviews, @gianm , @capistrant !

GWphua pushed a commit to GWphua/druid that referenced this pull request Mar 11, 2026
@kfaraz @GWphua
Add minor fixes to follow up apache#19091 (apache#19119)
fa0b3fb 
* Add minor fixes to follow up apache#19091

* Reset state if scaling fails

* Add anotehr test

* Fixes

* Remove extra subtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gianm gianm gianm approved these changes

@capistrant capistrant capistrant approved these changes

Assignees

No one assigned

Labels

Area - Ingestion

Projects

None yet

Milestone

37.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kfaraz @gianm @capistrant