Skip to content

fix: make BrokerDynamicConfig backwards-compatible#19120

Merged
jtuglu1 merged 3 commits intoapache:masterfrom
jtuglu1:fix-master-build
Mar 10, 2026
Merged

fix: make BrokerDynamicConfig backwards-compatible#19120
jtuglu1 merged 3 commits intoapache:masterfrom
jtuglu1:fix-master-build

Conversation

@jtuglu1
Copy link
Copy Markdown
Contributor

@jtuglu1 jtuglu1 commented Mar 10, 2026

Description

Master tests are breaking. Experimental branch to fix them

  • Rolling-forward deployment (HEAD broker -> v31 coordinator): receives empty broker dynamic config (same as if DNE)
  • Rolling-backward deployment (v31 broker -> HEAD coordinator): receives empty broker dynamic config (old broker is unaware of new API)

Release note

Make BrokerDynamicConfig backwards-compatible. By default, brokers who poll coordinators without the broker dynamic config endpoint (and receive a 404) will return an empty BrokerDynamicConfig.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 marked this pull request as draft March 10, 2026 06:16
@jtuglu1 jtuglu1 changed the title [DO NOT MERGE] Fix build Make BrokerDynamicConfig backwards-compatible Mar 10, 2026
@jtuglu1 jtuglu1 marked this pull request as ready for review March 10, 2026 07:54
@jtuglu1 jtuglu1 requested a review from kfaraz March 10, 2026 07:59
@jtuglu1 jtuglu1 force-pushed the fix-master-build branch 2 times, most recently from 51061c1 to a59abb4 Compare March 10, 2026 08:31
@jtuglu1 jtuglu1 changed the title Make BrokerDynamicConfig backwards-compatible fix: make BrokerDynamicConfig backwards-compatible Mar 10, 2026
@jtuglu1 jtuglu1 merged commit b7ac0bf into apache:master Mar 10, 2026
37 checks passed
@github-actions github-actions bot added this to the 37.0.0 milestone Mar 10, 2026
@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Mar 10, 2026

Thanks for the prompt fix, @jtuglu1 !

GWphua pushed a commit to GWphua/druid that referenced this pull request Mar 11, 2026
Make BrokerDynamicConfig backwards-compatible. By default, brokers who poll coordinators without the broker dynamic config endpoint (and receive a 404) will return an empty BrokerDynamicConfig.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants