fix: preserve GROUPING SET dimensions with single-value filter #19285
Merged
jtuglu1 merged 2 commits intoMay 18, 2026
Merged
Conversation
Member
|
The changes LGTM, no correctness issues found. |
Member
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
This is an automated review by Codex GPT-5
Contributor
Author
|
Thanks @FrankChen021 for review. @a2l007 can you please have a look and lets merge it. |
Contributor
Author
|
@jtuglu1 Please have a look. |
jtuglu1
reviewed
May 17, 2026
Contributor
jtuglu1
left a comment
There was a problem hiding this comment.
Can we add some quidem tests?
21560cb to
50ad101
Compare
Member
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the updated code for correctness, edge cases, concurrency, lifecycle, and integration risks; no issues found.
Reviewed 3 of 3 changed files.
This is an automated review by Codex GPT-5.5
jtuglu1
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13204
Description
Before (incorrect):
After (correct):
Fixed Grouping.applyProject() to preserve non-literal dimensions (and literal dimensions referenced in non-empty
subtotals) when Subtotals.hasEffect() is true, preventing single-value filter dimensions from being dropped and
causing incorrect non-null values in GROUPING SET subtotal rows.
Release note
Fixed a bug where a SQL query using GROUPING SETS with a single-value WHERE filter on a grouped dimension would return
the filtered value instead of null in subtotal rows that exclude that dimension. For example, WHERE dim2 = 'a' GROUP
BY GROUPING SETS ((dim1, dim2), (dim1)) now correctly returns null for dim2 in the (dim1) subtotal rows instead of
repeating 'a'.
This PR has: