feat: support scaling direction-aware cooldown for task auto-scalers#19286
Conversation
c72942f to
fc9c5cb
Compare
52e327f to
164f891
Compare
164f891 to
7fd9d61
Compare
6fe7359 to
ad264b0
Compare
ad264b0 to
757cbde
Compare
757cbde to
96f9f68
Compare
96f9f68 to
8f4bfc5
Compare
8f4bfc5 to
cadba38
Compare
|
@jtuglu1 , cost-based auto scaler already uses a The functionality of the cc: @Fly-Style |
Sure, I always want to reduce config bloat. However, I'd prefer to settle on a conventional naming scheme if possible (e.g. |
c48f082 to
752b235
Compare
6d68660 to
a9d469f
Compare
Fly-Style
left a comment
There was a problem hiding this comment.
Thank you for your contribution! The patch has nice direction, some polishing and we will be glad to merge it.
008d2f6 to
213d73d
Compare
4db2965 to
68baa70
Compare
68baa70 to
50e1c9b
Compare
1ff1d4b to
21579d8
Compare
Fly-Style
left a comment
There was a problem hiding this comment.
Really like the improvement, clear differentiation between scale-up and scale-down, while preserving old behaviour as a fallback. LGTM!
ee8ccc6 to
612e20f
Compare
Description
Adds support for configuring different cooldowns for scaling direction. While both scaling actions do cause temporary disruption to ingestion, scaling down can cause more disruption than scaling up due to having less resources than when you started to recover from lag. Therefore, to allow for aggressive scale up while having a more conservative scale-down approach, this adds configuration for cool down period for both directions. Cool down for a specific scaling direction is evaluated as follows:
minScaleUpDelay/minScaleDownDelayminTriggerScaleActionFrequencyMillis(marked as deprecated)600000.This also does the following:
ScaleActionSupplierwhich makes the contract clear for auto-scalers who want to implement it.Release note
Adds support for configuring different cooldowns for scaling direction for streaming task auto-scalers.
This PR has: