fix: Emit sys metrics from k8s peons.#19305
Merged
gianm merged 2 commits intoapache:masterfrom Apr 16, 2026
Merged
Conversation
Currently the SysMonitor and OshiSysMonitor are both skipped for peons, on the logic that they are redundant to the MiddleManager (see apache#12802). However, with the Kubernetes runner, we launch peons directly and we want them to emit sys metrics. To make it possible to differentiate these cases, this patch adds a property "druid.peon.managed" that informs the MetricsModule that the peon is managed by another process and should not emit metrics.
capistrant
reviewed
Apr 14, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
Nice idea. The MetricsModuleTest fail is legit as the change breaks the validation since the new property is not set there, to get the noop monitor. Other test fails look unrelated
capistrant
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the SysMonitor and OshiSysMonitor are both skipped for peons, on the logic that they are redundant to the MiddleManager (see #12802). However, with the Kubernetes runner, we launch peons directly and we want them to emit sys metrics.
To make it possible to differentiate these cases, this patch adds a property "druid.peon.managed" that informs the MetricsModule that the peon is managed by another process and should not emit metrics.