minor: configure spotless#19308
Open
kgyrtkirk wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Querying
Area - Metrics/Event Emitting
Area - Segment Format and Ser/De
Area - Streaming Ingestion
Area - Lookups
Area - Dependencies
Kubernetes
Area - Ingestion
Area - MSQ
Member
|
The changes LGTM, no correctness issues found. |
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
This is an automated review by Codex GPT-5
| </excludes> | ||
| <cleanthat> | ||
| <version>2.25</version> | ||
| <sourceJdk>${maven.compiler.source}</sourceJdk> |
Member
There was a problem hiding this comment.
[P2] Use the Java 17 release for CleanThat
The new Spotless/CleanThat configuration uses ${maven.compiler.source}, which resolves from the Apache parent to 1.8, while this repo compiles with ${maven.compiler.release} set to Java 17 and already contains Java 17 syntax such as text blocks and records. Since Spotless runs during validate across modules, CleanThat can parse/rewrite valid project sources as Java 8 or fail on them, breaking normal builds. Point sourceJdk at ${maven.compiler.release} or ${java.version} instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotless could do a little bit more than checkstyle which is only pointing out where the problems are - it also provides a way to fix issues.
This changeset configures the importorder and some other simpler rules.
I wanted to also configure the formatter - but that changes indentation in a lot of files; haven't figured out a way to avoid most changes which seem to be just noise.
Even the import order changes a lot of files; there are a lot of files where a blank line between
javaxandjavawas missing.The real meaningfull changes could be viewed with: