Skip to content

docs: add caution re: schema auto discovery#19403

Merged
317brian merged 8 commits into
apache:masterfrom
317brian:kafkainputformat-docs-update
May 14, 2026
Merged

docs: add caution re: schema auto discovery#19403
317brian merged 8 commits into
apache:masterfrom
317brian:kafkainputformat-docs-update

Conversation

@317brian
Copy link
Copy Markdown
Contributor

@317brian 317brian commented May 4, 2026 •
edited
Loading

Description

Adds info about

  • 2 optional Kafka parameters
  • Schema auto-discovery can lead to you ingesting more columns than you intend

This PR has:

  • been self-reviewed.

@317brian 317brian force-pushed the kafkainputformat-docs-update branch from bce50fe to c441423 Compare May 4, 2026 19:54
@317brian 317brian marked this pull request as ready for review May 5, 2026 16:48
@317brian 317brian requested review from kfaraz and techdocsmith May 5, 2026 16:50
FrankChen021
FrankChen021 reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

This is an automated review by Codex GPT-5

writer-jill
writer-jill approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@writer-jill writer-jill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions, LGTM

Comment thread docs/ingestion/ingestion-spec.md Outdated
Comment thread docs/ingestion/schema-design.md Outdated
317brian and others added 2 commits May 12, 2026 12:33
@317brian @writer-jill
Update docs/ingestion/ingestion-spec.md
1f8b6b7 
Co-authored-by: Jill Osborne <jill.osborne@imply.io>
@317brian @writer-jill
Update docs/ingestion/schema-design.md
35d0b5f 
Co-authored-by: Jill Osborne <jill.osborne@imply.io>
FrankChen021
FrankChen021 reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 3 of 3 changed files.

This is an automated review by Codex GPT-5.5

techdocsmith
techdocsmith requested changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylistic suggestion

Comment thread docs/ingestion/schema-design.md Outdated
@317brian @techdocsmith
Update docs/ingestion/schema-design.md
8951cee 
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
@317brian 317brian requested a review from techdocsmith May 13, 2026 22:43
techdocsmith
techdocsmith approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FrankChen021
FrankChen021 reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the incremental schema-design update, the full docs diff, and the Kafka input format implementation for partition/offset defaults and schema-discovery behavior; no correctness issues found.

Reviewed 3 of 3 changed files.

This is an automated review by Codex GPT-5.5

@317brian 317brian merged commit fb83544 into apache:master May 14, 2026
8 checks passed
@github-actions github-actions Bot added this to the 38.0.0 milestone May 14, 2026
@317brian 317brian deleted the kafkainputformat-docs-update branch May 15, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrankChen021 FrankChen021 FrankChen021 left review comments

@techdocsmith techdocsmith techdocsmith approved these changes

@kfaraz kfaraz Awaiting requested review from kfaraz

+1 more reviewer

@writer-jill writer-jill writer-jill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

38.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@317brian @FrankChen021 @techdocsmith @writer-jill