docs: catch upgrade notes page up#19447
Merged
Merged
Conversation
(cherry picked from commit 2ea198c)
cecemei
approved these changes
May 12, 2026
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 2 |
| Total | 3 |
Reviewed 1 of 1 changed files.
This is an automated review by Codex GPT-5.5
| PRIMARY KEY (fingerprint), | ||
| ); | ||
|
|
||
| CREATE INDEX idx_druid_compactionStates_used ON druid_compactionStates(used, used_status_last_updated); |
Member
There was a problem hiding this comment.
[P2] Fix the manual indexingStates DDL before publishing it
The manual Postgres DDL for operators with createTables disabled does not create a runnable schema: it creates druid_indexingStates, leaves a trailing comma after PRIMARY KEY, then creates the index on druid_compactionStates, which is not the table Druid uses. SQLMetadataConnector creates the indexingStates table and indexes that same table, so following this upgrade note as written will fail before the required migration is complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has: