Skip to content

fix: emit query/node/{bytes/time} metrics on query failure to data nodes#19453

Merged
jtuglu1 merged 1 commit into
apache:masterfrom
jtuglu1:debug-leaking-historical-connections
May 12, 2026
Merged

fix: emit query/node/{bytes/time} metrics on query failure to data nodes#19453
jtuglu1 merged 1 commit into
apache:masterfrom
jtuglu1:debug-leaking-historical-connections

Conversation

@jtuglu1
Copy link
Copy Markdown
Contributor

@jtuglu1 jtuglu1 commented May 11, 2026

Description

Failed requests to data nodes (e.g. timeouts) will not log query/node/bytes, query/node/time, nor any backpressure metrics which are all useful in debugging bottlenecks for queries. Make sure these are emitted irrespective of whether the query was successful or not.

Release note

Emit query/node/{bytes/time} and backpressure metrics even on query failure to data nodes.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 requested a review from maytasm May 11, 2026 23:54
@jtuglu1 jtuglu1 force-pushed the debug-leaking-historical-connections branch from 1e2355e to b17fb8b Compare May 11, 2026 23:55
Copy link
Copy Markdown
Contributor

@maytasm maytasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtuglu1 jtuglu1 changed the title fix: emit query/node/{bytes/time} metrics even on query failure to data nodes fix: emit query/node/{bytes/time} metrics on query failure to data nodes May 12, 2026
@jtuglu1 jtuglu1 merged commit 3bb525b into apache:master May 12, 2026
39 checks passed
@github-actions github-actions Bot added this to the 38.0.0 milestone May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants